Config values that come from plugins are now colored properly (purple) #6036
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6024
User facing changelog
Config values that come from plugins are now colored properly (purple) in the settings panel.
Before:
After:
Additional details
Tests were passing as they were using configuration data that was not completely representative of actual config data; i.e. the configuration's "from" value was set to "plugins" in the test, but actually has the value of "plugin."
Tests were altered to account for the above and SCSS styles were retargeted to the new className,
.plugin
.How has the user experience changed?
The UX will now highlight config values that come from a plugin in the correct shade of purple. This also extends to nested values.
PR Tasks