Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert command actions tests to Javascript #6591

Closed
wants to merge 14 commits into from
Closed

Convert command actions tests to Javascript #6591

wants to merge 14 commits into from

Conversation

clarmso
Copy link
Contributor

@clarmso clarmso commented Feb 28, 2020

This PR consists of the command actions tests from the driver package converted to Javascript from Coffeescript. The conversion has been done via the following command:

"command": "yarn decaffeinate-bulk convert --file ${file} ${file}",

I've converted the files in as few commits as possible. (bulk-decaffeinate creates commits for stages of the conversion.) Please do not squash this commit. :)

A part of #2690

User facing changelog

No user facing changelog specific to these tests should be needed.

Additional details

This PR is a part of continuous improvement in maintaining the codebase. We hope the codebase will be in Typescript. :) Javascript is an intermediate step.

I've reviewed the results of the bulk-decaffeinate command. I've ensured the following:

  • arrow functions are used if applicable. The remaining use of the function() notation is necessary. (Example: use of "this" keyword in the tests)
  • Remove unnecessary returns.
  • Remove variable declarations that are unnecessary.

How has the user experience changed?

No noticeable changes should be detected by the developers and the users. The new version of the tests should work the same as the old Coffeescript ones.

PR Tasks

  • Have tests been added/updated?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 28, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@jennifer-shehane
Copy link
Member

@clarmso Couple of lint warnings

/root/cypress/packages/driver/test/cypress/integration/commands/actions/check_spec.js
   635:43  error  Missing trailing comma  comma-dangle
  1181:43  error  Missing trailing comma  comma-dangle

@clarmso
Copy link
Contributor Author

clarmso commented Feb 29, 2020

@jennifer-shehane Oh darn. I didn't catch the lint error yesterday. (Scratching head...) It should be fixed now. :)

@clarmso clarmso changed the title [WIP] Convert command actions tests to Javascript Convert command actions tests to Javascript Feb 29, 2020
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clarmso Continuously merging in the develop branch and making more commits is going to mess up the final commit. We don't squash commits for decaffeinate, so need this PR left to the maximum of the decaffeinate commits + 1 cleanup commit. Is there any way you can clean up commits here?

@clarmso
Copy link
Contributor Author

clarmso commented Mar 5, 2020

My git squash/rebase is a fail again. :( Let me include my change in a new branch. (It's quicker...)

EDIT: See #6647

@clarmso clarmso closed this Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants