Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade extract-zip to address vulnerability #6845

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Upgrade extract-zip to address vulnerability #6845

merged 2 commits into from
Mar 26, 2020

Conversation

karlhorky
Copy link
Contributor

Reference: #6793

User facing changelog

Versions of extract-zip before 1.6.8 depended on a vulnerable version of minimist via mkdirp:

max-mapper/extract-zip#85 (comment)

Minimist vulnerability: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764

How has the user experience changed?

Less security vulnerabilities.

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

Versions of extract-zip before `1.6.8` depended on a vulnerable version of `minimist` via `mkdirp`:

max-mapper/extract-zip#85 (comment)

Minimist vulnerability: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 25, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@CLAassistant
Copy link

CLAassistant commented Mar 25, 2020

CLA assistant check
All committers have signed the CLA.

@khitrenovich
Copy link

Looks like updated lock file is missing from the PR.

@karlhorky
Copy link
Contributor Author

@khitrenovich thanks, updated!

@jennifer-shehane jennifer-shehane merged commit d7f6f61 into cypress-io:develop Mar 26, 2020
@karlhorky
Copy link
Contributor Author

Thanks for the merge @jennifer-shehane! Will this be released with 4.2.1?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 30, 2020

Released in 4.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.3.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants