Decaff driver part 6 #7320
Merged
Decaff driver part 6 #7320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to .js decaffeinate: Rename trigger_spec.coffee from .coffee to .js
decaffeinate: Convert trigger_spec.coffee to JS
… other files check_spec.js focus_spec.js hover_spec.js scroll_spec.js select_spec.js submit_spec.js agents_spec.js aliasing_spec.js angular_spec.js decaffeinate: Run post-processing cleanups on trigger_spec.coffee
|
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
|
I locally tested the failures and they're all flaky tests. |
jennifer-shehane
approved these changes
May 13, 2020
| }) | ||
|
|
||
| it('changes the subject when matching values even if noop', () => { | ||
| const checked = $('<input type=\'checkbox\' name=\'colors\' value=\'blue\' checked>') |
There was a problem hiding this comment.
Probably would prefer to change selectors to double quotes instead of \' when not relevant to code execution.
Suggested change
| const checked = $('<input type=\'checkbox\' name=\'colors\' value=\'blue\' checked>') | |
| const checked = $('<input type="checkbox" name="colors" value="blue" checked>') |
| ] | ||
|
|
||
| messages.forEach((msg) => { | ||
| expect(this.lastLog.get('message')).to.include(msg) |
There was a problem hiding this comment.
This change shouldn't matter unless the test was intended to also test the order of the messages printed. By the test title it seems like it's not testing that, but I can't be sure of the original intention.
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2690
NEVER SQUASH THIS PR.