Decaff driver (final)

[sainthkh]

Part of #2690

Final decaff of the driver package.

NEVER SQUASH THIS PR.

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[sainthkh]

It seems that flaky test happened.

[jennifer-shehane]

Thanks again for doing this! We're almost there. 😄

[jennifer-shehane]

but this same error adds a newline to the snapshot snapshot due to an update in error_messages, shouldn't be double newlines here I think.

[sainthkh]

This problem needs a research.

When I reverted the change and run the tests on my local Ubuntu, it works. But when I pushed it, it fails.

[sainthkh]

I still don't know why it happened. But the fix was easy.

[jennifer-shehane]

This appears to be remove a newline from the error message due to an update in error_messages.

[jennifer-shehane]

There's something about the cyStripIndent function that's not the same as previous spacing. Something about it changes the error message in the snapshotted values.

[sainthkh]

Another flaky failure.

[jennifer-shehane]

I think we may need to look closer at these failures. They are failing within some tests that were decaffeinated, although I don't understand why that would affect anything. But, I've rerun these a lot and they keep failing.

I haven't seen this specific error in other PRs.

[sainthkh]

• Fixed conflicts and rebased. Interestingly, socket fail didn't happen!
• I ran all tests locally with Firefox. But there was no problem.

[jennifer-shehane]

Perfect! If this is all the coffeescript out, I'm not sure if we had any code around transpiling that could be removed, but this could be removed now if so.

[sainthkh]

@jennifer-shehane Unfortunately, there are a lot of coffeescript codes in packages/server. We can remove coffeescript-related tools after they're converted.