Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: add env variable to force scaffolding #7558

Merged
merged 3 commits into from Jun 3, 2020

Conversation

bahmutov
Copy link
Contributor

@bahmutov bahmutov commented Jun 1, 2020

User facing changelog

Nothing, this is an internal feature useful to testing

Additional details

We now will be able to easily run 2 tests

How has the user experience changed?

You can scaffold new Cypress project with example specs

npm init -y
npm i -D cypress
echo '{}' >> cypress.json
CYPRESS_INTERNAL_FORCE_SCAFFOLD=1 npx cypress run

PR Tasks

  • Have tests been added/updated? Added unit tests and e2e test job
  • Has the original issue been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 1, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@cypress
Copy link

cypress bot commented Jun 1, 2020



Test summary

7445 0 104 0


Run details

Project cypress
Status Passed
Commit 3c61d60
Started Jun 2, 2020 3:25 PM
Ended Jun 2, 2020 3:32 PM
Duration 06:26 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

packages/server/test/unit/project_spec.js Show resolved Hide resolved
packages/server/lib/project.js Show resolved Hide resolved
packages/server/lib/project.js Show resolved Hide resolved
@bahmutov
Copy link
Contributor Author

bahmutov commented Jun 2, 2020

@jennifer-shehane I have added unit test, and if you feel the text changes are necessary, feel free to commit your suggestions

@bahmutov bahmutov changed the title add env variable to force scaffolding internal: add env variable to force scaffolding Jun 3, 2020
@bahmutov bahmutov merged commit 3b40f74 into develop Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Force scaffolding in headless mode
2 participants