chore: decaffeinate server tests, scripts, other files #7591

flotwig · 2020-06-04T21:07:35Z

Partially addresses Proposal: Convert codebase CoffeeScript => JS => TypeScript #2690

User facing changelog

n/a

Additional details

once this merges, our only remaining .coffee files are test fixtures:

packages/rewriter/test/fixtures/test.coffee
packages/server/test/support/fixtures/ids/app.coffee
packages/server/test/support/fixtures/ids/existing.coffee
packages/server/test/support/fixtures/ids/simple.coffee
packages/server/test/support/fixtures/projects/busted-support-file/cypress/integration/app_spec.coffee
packages/server/test/support/fixtures/projects/config-with-invalid-browser/cypress/integration/app_spec.coffee
packages/server/test/support/fixtures/projects/config-with-invalid-browser/cypress/plugins/index.coffee
packages/server/test/support/fixtures/projects/config-with-invalid-viewport/cypress/integration/app_spec.coffee
packages/server/test/support/fixtures/projects/config-with-invalid-viewport/cypress/plugins/index.coffee
packages/server/test/support/fixtures/projects/cookies/cypress/integration/app_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/assertions_failing_outside_of_test_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/assertions_passing_outside_of_test_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/async_timeouts_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/base_url_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/blacklist_hosts_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/browserify_babel_es2015_passing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/cache_clearing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/cache_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/caught_async_sync_test_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/commands_outside_of_test_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/config_failing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/config_passing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/cookies_spec_baseurl.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/cookies_spec_no_baseurl.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/domain_2_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/domain_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/ended_early_failing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/fast_visit_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/form_submission_failing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/form_submission_multipart_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/form_submission_passing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/go_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/hook_caught_error_failing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/hook_uncaught_error_events_failing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/hook_uncaught_error_failing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/hook_uncaught_root_error_failing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/iframe_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/images_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/issue_149_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/issue_173_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/issue_2196_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/issue_674_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/js_error_handling_failing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/nested-1/nested-2/nested-3/spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/nested-1/nested-2/nested-3/stdout_specfile.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/nested-1/nested-2/nested-3/stdout_specfile_display_spec_with_a_really_long_name_that_never_has_a_line_break_or_new_line.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/nested-1/nested-2/screenshot_nested_file_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/only_multiple_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/only_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/page_loading_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/promises_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/record_error_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/record_fail_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/record_pass_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/record_uncaught_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/request_http_network_error_failing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/request_long_http_props_failing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/request_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/request_status_code_failing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/return_value_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/screenshot_element_capture_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/screenshot_fullpage_capture_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/screenshot_viewport_capture_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/server_sent_events_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/simple_failing_hook_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/simple_failing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/simple_hooks_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/simple_passing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/simple_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/stdout_failing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/stdout_passing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/subdomain_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/task_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/uncaught_during_hook_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/uncaught_during_test_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/uncaught_synchronous_before_tests_parsed.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/uncaught_synchronous_during_hook_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/user_agent_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/video_compression_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/viewport_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/visit_file_404_response_failing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/visit_http_500_response_failing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/visit_http_network_error_failing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/visit_http_timeout_failing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/visit_non_html_content_type_failing_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/visit_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/web_security_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/websockets_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/window_open_spec.coffee
packages/server/test/support/fixtures/projects/e2e/cypress/integration/xhr_spec.coffee
packages/server/test/support/fixtures/projects/e2e/lib/foo.coffee
packages/server/test/support/fixtures/projects/failures/cypress/integration/app_spec.coffee
packages/server/test/support/fixtures/projects/failures/cypress/integration/syntax_error.coffee
packages/server/test/support/fixtures/projects/ids/cypress/integration/foo.coffee
packages/server/test/support/fixtures/projects/ids/cypress/integration/noop.coffee
packages/server/test/support/fixtures/projects/multiple-task-registrations/cypress/integration/multiple_task_registrations_spec.coffee
packages/server/test/support/fixtures/projects/no-scaffolding/cypress/integration/app_spec.coffee
packages/server/test/support/fixtures/projects/plugin-after-screenshot/cypress/integration/after_screenshot_spec.coffee
packages/server/test/support/fixtures/projects/plugin-browser/cypress/integration/app_spec.coffee
packages/server/test/support/fixtures/projects/plugin-browser/cypress/plugins/index.coffee
packages/server/test/support/fixtures/projects/plugin-config/cypress/integration/app_spec.coffee
packages/server/test/support/fixtures/projects/plugin-event-deprecated/cypress/integration/app_spec.coffee
packages/server/test/support/fixtures/projects/plugin-extension/cypress/integration/app_spec.coffee
packages/server/test/support/fixtures/projects/plugin-extension/cypress/plugins/index.coffee
packages/server/test/support/fixtures/projects/plugin-filter-browsers/cypress/integration/app_spec.coffee
packages/server/test/support/fixtures/projects/plugin-filter-browsers/cypress/plugins/index.coffee
packages/server/test/support/fixtures/projects/plugin-returns-bad-config/cypress/integration/app_spec.coffee
packages/server/test/support/fixtures/projects/plugin-returns-bad-config/cypress/plugins/index.coffee
packages/server/test/support/fixtures/projects/plugin-returns-empty-browsers-list/cypress/integration/app_spec.coffee
packages/server/test/support/fixtures/projects/plugin-returns-empty-browsers-list/cypress/plugins/index.coffee
packages/server/test/support/fixtures/projects/plugin-returns-invalid-browser/cypress/integration/app_spec.coffee
packages/server/test/support/fixtures/projects/plugin-returns-invalid-browser/cypress/plugins/index.coffee
packages/server/test/support/fixtures/projects/plugins-absolute-path/cypress/integration/absolute_spec.coffee
packages/server/test/support/fixtures/projects/plugins-async-error/cypress/integration/app_spec.coffee
packages/server/test/support/fixtures/projects/task-not-registered/cypress/integration/task_not_registered_spec.coffee
packages/server/test/support/fixtures/projects/todos/lib/my_coffee.coffee
packages/server/test/support/fixtures/projects/todos/tests/_fixtures/account.coffee
packages/server/test/support/fixtures/projects/todos/tests/_fixtures/bad_coffee.coffee
packages/server/test/support/fixtures/projects/todos/tests/_fixtures/bar.coffee
packages/server/test/support/fixtures/projects/todos/tests/_fixtures/foo.coffee
packages/server/test/support/fixtures/projects/todos/tests/_fixtures/no_format.coffee
packages/server/test/support/fixtures/projects/todos/tests/_fixtures/trailing_new_line.coffee
packages/server/test/support/fixtures/projects/todos/tests/sub/sub_test.coffee
packages/server/test/support/fixtures/projects/todos/tests/test2.coffee
packages/server/test/support/fixtures/projects/uncaught-support-file/cypress/integration/spec.coffee
packages/server/test/support/fixtures/projects/various-file-types/cypress/integration/coffee_spec.coffee
packages/server/test/support/fixtures/projects/working-preprocessor/cypress/integration/app_spec.coffee
packages/server/test/support/fixtures/server/coffee_sample.coffee
packages/server/test/support/fixtures/server/syntax_error.coffee
packages/server/test/support/fixtures/server/throws_error.coffee

How has the user experience changed?

PR Tasks

Have tests been added/updated?
[na] Has the original issue been tagged with a release in ZenHub?
[na] Has a PR for user-facing changes been opened in cypress-documentation?
[na] Have API changes been updated in the type definitions?
[na] Have new configuration options been added to the cypress.schema.json?

DON'T SQUASH THIS

… .js

…her files

cypress-bot · 2020-06-04T21:07:36Z

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

The feature/bugfix is self-documenting from within the product.
The change provides the end user with a way to fix their problem (no dead ends).

Functionality

The code works and performs its intended function with the correct logic.
Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

The code is readable (too many nested 'if's are a bad sign).
Names used for variables, methods, etc, clearly describe their function.
The code is easy to understood and there are relevant comments explaining.
New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
There are comments containing link(s) to the addressed issue (in tests and code).

Quality

The change does not reimplement code.
There's not a module from the ecosystem that should be used instead.
There is no redundant or duplicate code.
There are no irrelevant comments left in the code.
Tests are testing the code’s intended functionality in the best way possible.

Internal

The original issue has been tagged with a release in ZenHub.

cypress · 2020-06-04T21:26:06Z

Test summary

7530 • 0 • 117 • 0

Run details


Project	cypress
Status	Passed
Commit	`ea4c98d`
Started	Jun 5, 2020 8:26 PM
Ended	Jun 5, 2020 8:31 PM
Duration	05:55 💡
OS	Linux Debian - 10.1
Browser	Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

…-and-more

cypress-bot · 2020-06-08T20:35:37Z

Released in 4.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.8.0, please open a new issue.

flotwig added 4 commits June 4, 2020 15:25

decaffeinate: Rename index.coffee and 138 other files from .coffee to…

d3ac20f

… .js

decaffeinate: Convert index.coffee and 138 other files to JS

aa368c4

decaffeinate: Run post-processing cleanups on index.coffee and 138 ot…

76ddf33

…her files

cleanup decaf

9ea4979

flotwig changed the title ~~chrore: decaffeinate server tests, scripts, other files~~ chore: decaffeinate server tests, scripts, other files Jun 5, 2020

Merge remote-tracking branch 'origin/develop' into decaf-server-tests…

7805fb8

…-and-more

flotwig force-pushed the decaf-server-tests-and-more branch 2 times, most recently from a502af0 to 54c294d Compare June 5, 2020 17:40

fix tests after decaffeination

30137e5

flotwig force-pushed the decaf-server-tests-and-more branch from 54c294d to 30137e5 Compare June 5, 2020 17:58

flotwig marked this pull request as ready for review June 5, 2020 18:11

flotwig requested a review from kuceb June 5, 2020 18:16

fix decaf header, server/test/e2e

ea4c98d

kuceb approved these changes Jun 5, 2020

View reviewed changes

flotwig merged commit 1875027 into develop Jun 5, 2020

kuceb mentioned this pull request Jun 5, 2020

meta: fix develop history, undo effect of squashed decaf PR #7608

Merged

cypress-bot bot locked as resolved and limited conversation to collaborators Jun 8, 2020

flotwig deleted the decaf-server-tests-and-more branch January 24, 2022 18:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: decaffeinate server tests, scripts, other files #7591

chore: decaffeinate server tests, scripts, other files #7591

flotwig commented Jun 4, 2020 •

edited

cypress-bot bot commented Jun 4, 2020

cypress bot commented Jun 4, 2020 •

edited

cypress-bot bot commented Jun 8, 2020

chore: decaffeinate server tests, scripts, other files #7591

chore: decaffeinate server tests, scripts, other files #7591

Conversation

flotwig commented Jun 4, 2020 • edited

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

DON'T SQUASH THIS

cypress-bot bot commented Jun 4, 2020

PR Review Checklist

User Experience

Functionality

Maintainability

Quality

Internal

cypress bot commented Jun 4, 2020 • edited

Test summary

Run details

cypress-bot bot commented Jun 8, 2020

flotwig commented Jun 4, 2020 •

edited

cypress bot commented Jun 4, 2020 •

edited