-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove non-test-related coffeescript references #7605
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
25d99b3
to
13c71a9
Compare
2a9c385
to
5f93a64
Compare
5f93a64
to
9ba2ad1
Compare
9ba2ad1
to
9ec9883
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I think it would have been nice to maintain the history of the coffee files that were deleted/replaced with js files like we do other decaffeinations, but...I can see that not being as important for these fixture/plugin files. I dunno, what do you think?
-
Whats the fate of all these coffee files? I guess they don't technically have to be moved over, but probably should be unless they're specific to coffeescript test files. https://github.com/cypress-io/cypress/tree/develop/packages/server/test/support/fixtures/projects/e2e/cypress/integration
-
Also, what's the point of the coffee package, it's literally just exporting the
coffeescript
package. I think we can just requirecoffeescript
1.12.7
package in server now directly since it isn't reused.
|
9ec9883
to
6aecc49
Compare
6aecc49
to
e0b31cb
Compare
@jennifer-shehane updated it to remove |
User facing changelog
n/a
Additional details
cy.fixture
, which is the last usage of@packages/coffee
@packages/coffee/register
within the child bootstrap code, which only works when CYPRESS_INTERNAL_ENV !== production. so not user facingHow has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?