-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: "RangeError: Index out of range | The value of "offset" is out of range" #9281
Conversation
Thanks for taking the time to open a PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks great. I've added a test to ensure this fixes the issue and we don't have a regression in the future.
This is good to merge in if all the tests pass.
@jennifer-shehane good to hear. Any idea why the circleci checks were not coming in for me? |
@santam85 Sometimes they don't run for certain outside contributors and it's not obvious why. I haven't had time to investigate why |
Closes #2034
Some browsers return in certain situations a negative offset for element positions, and this is generally not an issue in Cypress, until it attempts to crop a screenshot.