fix: Fix no-assigning-return-values 'cannot read property callee of u…

…ndefined' error (fixes #8)
cypress-io · Nov 5, 2018 · 13ff374 · 13ff374
2 parents 27c2b12 + c7b96f7
commit 13ff374
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/lib/rules/no-assigning-return-values.js b/lib/rules/no-assigning-return-values.js
@@ -35,6 +35,9 @@ function isCypressCommandDeclaration(declarator) {
   if (!declarator.init.callee) { return; }
 
   let object = declarator.init.callee.object;
+
+  if (!object)                 { return; }
+
   while (object.callee) {
     object = object.callee.object;
   }

diff --git a/tests/lib/rules/no-assigning-return-values.js b/tests/lib/rules/no-assigning-return-values.js
@@ -13,6 +13,7 @@ ruleTester.run('no-assigning-return-values', rule, {
     { code: 'var foo = true;', parserOptions },
     { code: 'let foo = true;', parserOptions },
     { code: 'const foo = true;', parserOptions },
+    { code: 'const foo = bar();', parserOptions },
     { code: 'cy.get("foo");', parserOptions },
     { code: 'cy.contains("foo").click();', parserOptions }
   ],