Apply suggestions from code review

cypress-io · Apr 28, 2023 · ad396fb · ad396fb
1 parent 84274f2
commit ad396fb
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/lib/rules/no-unnecessary-waiting.js b/lib/rules/no-unnecessary-waiting.js
@@ -60,7 +60,6 @@ function isIdentifierNumberConstArgument (node, scope) {
   const resolvedIdentifier = scope.references.find((ref) => ref.identifier === identifier).resolved
   const definition = resolvedIdentifier.defs[0]
   const isVariable = definition.type === 'Variable'
-  const isImportBinding = definition.type === 'ImportBinding'
 
   // const amount = 1000 or const amount = '@alias'
   // cy.wait(amount)
@@ -73,9 +72,7 @@ function isIdentifierNumberConstArgument (node, scope) {
   // import { WAIT } from './constants'
   // cy.wait(WAIT)
   // we don't know if WAIT is a number or alias '@someRequest', so don't fail
-  if (isImportBinding) {
-    return false
-  }
+  if (definition.type === 'ImportBinding') return false
 
   const param = definition.node.params[definition.index]