Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate internal linting to recommended plugins #177

Merged

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Apr 19, 2024

Issue

Changes

  1. Plugin dependencies used for internal linting are removed:
    • @cypress/eslint-plugin-dev
    • @cypress/eslint-plugin-json
    • @typescript-eslint/eslint-plugin
    • @typescript-eslint/parser
  2. Overrides for eslint-plugin-mocha are removed from package.json
  3. Plugins recommended by the ESLint documentation section Linting a Plugin are added, using each plugin's recommended configuration:
  4. The following plugin is also updated to a current version:
  5. .eslintrc.json is reconfigured for the above plugins. Some recommended rules of the form eslint-plugin/require-meta-* are temporarily disabled. These should be revisited in conjunction with the enhancements proposed by the ESLint team in PR Automate docs with eslint-doc-generator #115.

Verification

Ensure that npm run lint is successful on ESLint v7 and v8.

Prerequisites

@cypress-app-bot
Copy link

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review April 22, 2024 19:07
@MikeMcC399
Copy link
Collaborator Author

@jennifer-shehane

This is now ready for review and merge.

@MikeMcC399
Copy link
Collaborator Author

@jennifer-shehane jennifer-shehane merged commit 7ca920a into cypress-io:master Apr 23, 2024
6 checks passed
@MikeMcC399 MikeMcC399 deleted the migrate/internal-linting branch April 23, 2024 15:09
@cypress-app-bot
Copy link

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from @cypress/eslint-plugin-dev to supported plugins
3 participants