refactor: migrate internal linting to recommended plugins #177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
npm run lint
) were based on the npm module @cypress/eslint-plugin-dev. Since this module is not yet compatible with ESLint8.x
, a migration to this version has not been possible. PR chore: update eslint from version 7 to version 8 cypress#29355 aims to migrate @cypress/eslint-plugin-dev to ESLint8.x
, however a path to ESLint9.x
needs to be possible and the current PR for @cypress/eslint-plugin-dev does not cover this aspect.Changes
@cypress/eslint-plugin-dev
@cypress/eslint-plugin-json
@typescript-eslint/eslint-plugin
@typescript-eslint/parser
eslint-plugin-mocha
are removed frompackage.json
recommended
configuration:eslint-plugin-eslint-plugin@5
for compatibility with ESLint7.x
eslint-plugin-n@16
for compatibility with ESLint7.x
recommended
configuration..eslintrc.json
is reconfigured for the above plugins. Some recommended rules of the formeslint-plugin/require-meta-*
are temporarily disabled. These should be revisited in conjunction with the enhancements proposed by the ESLint team in PR Automate docs with eslint-doc-generator #115.Verification
Ensure that
npm run lint
is successful on ESLintv7
andv8
.Prerequisites
v7
andv8
.