test: drop testing of ESLint 4 #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This test needs to be removed as a "Required" test. |
|
@MikeMcC399 I removed the v4 job as a required job for branch protections |
MikeMcC399
force-pushed
the
remove/eslint-4-tests
branch
from
cd8120b
to
4811303
Compare
Thank you very much! |
jennifer-shehane
approved these changes
Apr 17, 2024
|
馃帀 This PR is included in version 3.0.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to issues:
npm cion repo source聽#153Issue
@cypress/eslint-plugin-dev@3.2.0 configured in this repo's
devDependenciescontainspeerDependencies:however
@typescript-eslint/parser@1.11.0 is only compatible with ESLint
5:This rules out the supported use of ESLint
4for dev linting tests in the repository.Change
Remove tests for ESLint
4.The last release of ESLint 4.x was eslint@4.19.1 released on March 22, 2018, more than 6 years ago. The current release is eslint@9.0.0 released on Apr 5, 2024.
This change does not prevent
eslint-plugin-cypressbeing installed and used with ESLint4therefore it is not a breaking change for end-users.There is an outdated note in README > Rules referring to ESLint
4.x. The issue #14, being referred to, is however already resolved. This should be cleaned up in a later migration step as the repo is moved towards supporting ESLint8.xcorrectly.