Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: display exact eslint version in circleci #183

Merged

Conversation

MikeMcC399
Copy link
Collaborator

Issue

When alternative versions of ESLint are installed by the circle.yml workflow, the version of ESLint is not logged. This makes troubleshooting more difficult.

In the current transition phase, whilst dependencies are being updated in incremental steps, it is unavoidable that peer dependency errors are logged. npm does not make it clear which version of ESLint it has chosen for installation.

Change

The exact version of ESLint is shown with the CLI option --version, for example v8.57.0:

npx eslint --version

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review April 22, 2024 14:26
@MikeMcC399 MikeMcC399 self-assigned this Apr 22, 2024
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcC399 Thanks for making the update so quickly!

@jennifer-shehane jennifer-shehane merged commit c4c75ef into cypress-io:master Apr 22, 2024
8 checks passed
@MikeMcC399 MikeMcC399 deleted the ci-show-eslint-version branch April 22, 2024 14:57
@cypress-app-bot
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants