Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update internal linting to eslint 8.57.0 #185

Merged

Conversation

MikeMcC399
Copy link
Collaborator

Issue

The repo is currently linting itself in CircleCI using ESLint 7.x. This causes a peer dependency warning from

npm WARN Could not resolve dependency:
npm WARN peer eslint@">=8" from eslint-plugin-es-x@7.6.0
npm WARN node_modules/eslint-plugin-n/node_modules/eslint-plugin-es-x
npm WARN   eslint-plugin-es-x@"^7.5.0" from eslint-plugin-n@16.6.2
npm WARN   node_modules/eslint-plugin-n

Change

Move internal linting to using ESLint 8.x and prevent peer dependency warnings.

Note that the two plugin versions above require ESLint >= 8.23.0, so for backwards compatibility, Circle CI tests with ESLint 7.x are changed to temporarily uninstall the incompatible plugins, which are not needed to run tests in Jest:

update to
eslint-plugin-eslint-plugin@6.0.0
eslint-plugin-n@17.2.1
prevent these plugins from use with ESLint 7.x in CircleCI Jest tests

chore(deps): update internal linting to eslint 8.57.0
@cypress-app-bot
Copy link

@MikeMcC399
Copy link
Collaborator Author

CircleCI results

There are no more peer dependency or other errors shown in the CircleCI pipeline jobs:

There is a deprecation warning in test-v8. This warning is described in

@MikeMcC399 MikeMcC399 self-assigned this Apr 23, 2024
@MikeMcC399 MikeMcC399 marked this pull request as ready for review April 23, 2024 14:59
@jennifer-shehane jennifer-shehane merged commit 8227cbc into cypress-io:master Apr 23, 2024
8 checks passed
@MikeMcC399 MikeMcC399 deleted the migrate/internal-linting-for-8 branch April 23, 2024 16:49
@cypress-app-bot
Copy link

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants