Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add empty meta.schema to no-option rules #187

Merged
merged 1 commit into from Apr 24, 2024

Conversation

MikeMcC399
Copy link
Collaborator

Issue

The plugin:eslint-plugin/recommended rules of eslint-plugin-eslint-plugin include the eslint-plugin/require-meta-schema rule. This rule currently fails for the following two Cypress rules if enabled:

Rule ID Description
no-async-before Prevent using async/await in Cypress test case
no-async-tests Prevent using async/await in Cypress test case

Other rules already have the meta.schema property set.

Documentation reference

According to Option Schemas

For rules that don't specify a meta.schema property, ESLint throws errors when any options are passed. If your rule doesn't have options, do not set schema: false, but simply omit the schema property or use schema: [], both of which prevent any options from being passed.

Changes

Add meta.schema: [] to the rules

Rule ID
no-async-before
no-async-tests

@cypress-app-bot
Copy link

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review April 24, 2024 14:17
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough. Thanks!

@jennifer-shehane jennifer-shehane merged commit 5c1b59a into cypress-io:master Apr 24, 2024
6 checks passed
@MikeMcC399 MikeMcC399 deleted the update/meta-schema branch April 24, 2024 15:15
@cypress-app-bot
Copy link

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants