docs: fix async further reading links #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This comment was marked as outdated.
This comment was marked as outdated.
jennifer-shehane
approved these changes
Apr 25, 2024
|
🎉 This PR is included in version 3.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The following rules documents contain outdated links concerning Promises:
The outdated links are:
The target
https://docs.cypress.io/guides/core-concepts/introduction-to-cypress.html#Commands-Are-Promisesdoes not exist.The target
https://docs.cypress.io/guides/core-concepts/introduction-to-cypress.html#Commands-Are-Not-Promisesdoes not exist.Changes
The Cypress documentation page https://docs.cypress.io/guides/core-concepts/introduction-to-cypress.html was changed by PR cypress-io/cypress-documentation#4148 in Oct 2021. The PR text explains that the
Commands-Are-PromisesandCommands-Are-Not-Promisessections were replaced for clarity.Commands-Are-PromisesandCommands-Are-Not-Promiseslinks using The Cypress Command Queuehttps://on.cypress.io/guides/core-concepts/introduction-to-cypress#The-Cypress-Command-Queue
https://on.cypress.io/guides/core-concepts/introduction-to-cypress#Mixing-Async-and-Sync-code
At the very bottom of Mixing Async and Sync code there is a good explanation of the topic: