chore: migrate to RuleTester v9

[MikeMcC399]

• Part 2: Following on from PR tests: save legacy tests #205

Situation

Tests in the tests/lib/rules which run internally under ESLint 7.x and 8.x are not compatible with ESLint 9.x.

The guide Migrate to 9.0 > FlatRuleTester is now RuleTester explains:

As announced in our blog post, the temporary FlatRuleTester class has been renamed to RuleTester, while the RuleTester class from v8.x has been removed. Additionally, the FlatRuleTester export from eslint/use-at-your-own-risk has been removed.

This is a breaking change for the tests.

Goal

The enhancement goal is to be able to test the repo rules using each of the supported versions of ESLint: 7.x, 8.x and 9.x.

Migration steps

Achieving the goal requires separating the tests into a legacy copy, for use with the RuleTester class of ESLint 7.x and 8.x, and another copy which will be migrated to use the RuleTester of ESLint 9.x.

The migration is done in two steps:

1. Create the legacy copy of tests, a script to use this copy and a modification to the CircleCI workflow. Done in PR tests: save legacy tests #205.
2. Modify the current copy of tests for compatibility with the new RuleTester class in ESLint 9.x. (This PR.)

Changes

This PR deals with the second step of modifying the current copy of tests for compatibility with the new RuleTester class in ESLint 9.x.

For all tests/lib/rules *.js test files:

1. harmonize tests to use the code block:

   const RuleTester = require('eslint').RuleTester
   const ruleTester = new RuleTester()

   according to the v9 > RuleTester documentation.
2. Harmonize other formating.
3. Change Remove unnecessary parserOptions to languageOptions. Edit: See chore: migrate to RuleTester v9 #207 (comment)
4. For tests/lib/rules/no-unnecessary-waiting.js remove the section which attempts to test disabling the rule. This is not compatible with the v9 RuleTester and it is attempting to test a function of ESLint rather than the rule itself.
5. For tests/lib/rules/unsafe-to-chain-command.js modify an incompatible option syntax in one rule.

For the CircleCI workflow

1. Create a new test in CircleCI for ESLint 9.x to use the modified current tests.

References

• Testing rules with flat config and the RuleTester class
• FlatRuleTester is now RuleTester
• v9 > RuleTester

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[MikeMcC399]

@jennifer-shehane

Since this PR is successful ci/circleci: test-v9 could now be added to the branch protection rules as "Required".

[MikeMcC399]

After the initial submission of this PR I realized that it is not necessary to migrate parserOptions to languageOptions for RuleTester v9 compatibility.

According to ESLint v9 Configure Language Options the defaults are:

• ecmaVersion: "latest"
• sourceType: "module"

and so it is not necessary to specify these explicitly in the tests.

I have updated the PR accordingly by removing the parserOptions to simplify the tests.

There were also some instances where an errors parameter was incorrectly applied to a valid case, so I removed these, although they were not negatively affecting the results of running the tests.