Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve markdown-link-check forbidden with renovate app link #690

Merged
merged 1 commit into from Jan 5, 2023

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Dec 28, 2022

This PR resolves a new issue that npm run check:markdown fails on GitHub when checking the link https://renovateapp.com/ in the README file. The error is HTTP 403 forbidden.

When run locally there is no failure and https://renovateapp.com/ redirects to https://renovatebot.com/ and then to https://www.mend.io/free-developer-tools/renovate/.

I have replaced the link
https://renovateapp.com/
by
https://github.com/renovatebot
and this passes the npm run check:markdown check on GitHub.

Problem analysis

CloudFront is blocking access to https://www.mend.io/free-developer-tools/renovate/ from GitHub by responding with 403 forbidden. A cy.visit('https://www.mend.io/free-developer-tools/renovate/) run on GitHub also fails.

curl -v https://www.mend.io/free-developer-tools/renovate/ -o /dev/null run on GitHub shows:

< HTTP/2 403 
< server: CloudFront
< content-type: text/html
< x-cache: Error from cloudfront

@MikeMcC399
Copy link
Collaborator Author

This is a high priority item since it will block the release of any new version through main.yml until it is merged.

@MikeMcC399
Copy link
Collaborator Author

@jaffrepaul

Please merge this PR as the markdown issue is blocking all other PRs from successful testing.

@jaffrepaul jaffrepaul merged commit d2a9e4e into cypress-io:master Jan 5, 2023
@MikeMcC399 MikeMcC399 deleted the fix/renovate-link branch January 5, 2023 16:53
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

🎉 This PR is included in version 5.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

kodiakhq bot added a commit to weareinreach/InReach that referenced this pull request Jan 9, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/cache](https://togithub.com/actions/cache) | action | digest | `4723a57` -> `58c146c` |
| [cypress-io/github-action](https://togithub.com/cypress-io/github-action) | action | patch | `v5.0.2` -> `v5.0.4` |

---

### Release Notes

<details>
<summary>cypress-io/github-action</summary>

### [`v5.0.4`](https://togithub.com/cypress-io/github-action/releases/tag/v5.0.4)

[Compare Source](https://togithub.com/cypress-io/github-action/compare/v5.0.3...v5.0.4)

**Update Dependencies**

-   [cypress-io/github-action#577
-   [cypress-io/github-action#653
-   [cypress-io/github-action#682
-   [cypress-io/github-action#704

**Docs/Tooling Updates**

-   [cypress-io/github-action#690

includes `/dist` rebuild

### [`v5.0.3`](https://togithub.com/cypress-io/github-action/releases/tag/v5.0.3)

[Compare Source](https://togithub.com/cypress-io/github-action/compare/v5.0.2...v5.0.3)

##### Bug Fixes

-   **deps:** update dependency got to v11.8.6 ([b5134f5](https://togithub.com/cypress-io/github-action/commit/b5134f53897bc8516473dc0e53f72382581de223))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/weareinreach/InReach).



PR-URL: #145
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants