Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade puppeteer to latest version #307

Closed

Conversation

ericapisani
Copy link

A reopen of #301 (though going to v15 instead of v13 because this is now the most recent version) as folks are still running into this on M1 laptops

Original description:

Puppeteer v10+ addresses an issue where installation would fail on Apple Silicon/M1, which is what was happening in this project as well prior to upgrading the package

Error that was being run into:

npm ERR! command sh -c node install.js
npm ERR! The chromium binary is not available for arm64.
npm ERR! If you are on Ubuntu, you can install with: 
npm ERR! 
npm ERR!  sudo apt install chromium
npm ERR! 
npm ERR! 
npm ERR!  sudo apt install chromium-browser
npm ERR! 
npm ERR! /Users/ericapisani/netlify/netlify-plugin-cypress/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserFetcher.js:115
npm ERR!                     throw new Error();
npm ERR!                     ^
npm ERR! 
npm ERR! Error
npm ERR!     at /Users/ericapisani/netlify/netlify-plugin-cypress/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserFetcher.js:115:27
npm ERR!     at FSReqCallback.oncomplete (node:fs:198:21)

@ianmacartney
Copy link

It seems circleci needs to be configured for netlify somehow, based on a brief look at the failing tests.
This seems related if someone has credentials to log in:

### Authentication (ci)
To authenticate `netlify` on CircleCI:
- grab the Settings > Site information > APP ID and set it as environment variable `NETLIFY_SITE_ID`
- generate new authentication token for CI from User Settings > Applications > New Access Token and set it as environment variable `NETLIFY_AUTH_TOKEN`

I cloned it and ran it locally (on an M1 mac) and got many of these failing tests to pass - config-file didn't work off the bat, missing some index.js - didn't look in further.

Methodology:
For each folder in tests I ran PORT=300 npm run start (to avoid the mac system process using port 5000)
I changed cypress.json to point at localhost:3000
For each folder I ran npm run test in another shell. Some didn't have a test script specified.

Not sure how to help further on that, but would love to have this resolved.

@Schoude
Copy link

Schoude commented Nov 9, 2022

This also concerns people that want to use newer CSS and HTML features like logical properties, inert or the <dialog> element in their website. As for me this plugins install a custom chromium 90 (latest release is 107 (!) now) which seems to not have implemented these features and therefore my tests on the CI fail but the tests in my dev environment pass...

@jaffrepaul
Copy link
Member

@ericapisani I'm looking into getting this up to date and tested. Can you address the merge conflicts here?

@jaffrepaul
Copy link
Member

@ericapisani scratch that. Now that I get a closer look at this and given how stale this PR got, I'm going to set up a new PR on this side.

@jaffrepaul jaffrepaul mentioned this pull request Feb 10, 2023
@jaffrepaul
Copy link
Member

A newer version of this PR, #320 was merged.

@jaffrepaul jaffrepaul closed this Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants