Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): resolve unsupported puppeteer message #343

Closed
wants to merge 3 commits into from

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented May 8, 2023

This PR wanted to resolve issue #336 ("npm WARN deprecated puppeteer@18.1.0: < 19.4.0 is no longer supported") and updates the dependency puppeteer to the latest 19.x.x version, which is 19.11.1.

(puppeteer 20.0.0 is a breaking change, so this version is not used.)

Furthermore the dependency netlify-cli is updated to 14.4.0. This resolves the issue that npm ci would otherwise fail with the message
"npm ERR! code EBADPLATFORM"
if puppeteer 18.2.1, 19.4.0 or 19.11.1 is installed.

jest is updated to 28.1.3, which is necessary after updating puppeteer.

Verification

Execute:

npm ci

No deprecation warning such as "npm WARN deprecated puppeteer@18.1.0: < 19.4.0 is no longer supported" should appear (although there will be many other deprecation warnings for other dependencies). Then execute

npm start

and in a separate terminal window

npm test

The test should be successful.

update puppeteer to 19.11.1
updated netlify-cli to 14.4.0
@netlify
Copy link

netlify bot commented May 8, 2023

👷 Deploy request for netlify-plugin-cypress pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 2456f85

@CLAassistant
Copy link

CLAassistant commented May 8, 2023

CLA assistant check
All committers have signed the CLA.

@MikeMcC399
Copy link
Contributor Author

All CI tests fail 🙁

@MikeMcC399
Copy link
Contributor Author

I should have read the CONTRIBUTING.md document first before attempting this PR. 🤔

I may be mistaken, but I don't think that I can get this PR to pass CI without being a member of the Cypress Netlify organization as I need to execute npx netlify link and authenticate.

I will leave it open as draft for the moment and expect to close it unless somebody from the core team can pick it up.

@MikeMcC399
Copy link
Contributor Author

@MikeMcC399
Copy link
Contributor Author

There are multiple inter-dependencies so this PR is unsuccessful in resolving the issue:

Updating jestto 28.1.3 does not work.
react-scripts is installed with 3.4.1 and requires exactly "jest": "24.9.0",

cd tests/config-file
npm run build
$ npm run build

> config-file@0.1.0 build
> ../../node_modules/.bin/react-scripts build


There might be a problem with the project dependency tree.
It is likely not a bug in Create React App, but something you need to fix locally.

The react-scripts package provided by Create React App requires a dependency:

  "jest": "24.9.0"

Don't try to install it manually: your package manager does it automatically.
However, a different version of jest was detected higher up in the tree:

  C:\Users\mikem\github\cypress-io\netlify-plugin-cypress\node_modules\jest (version: 28.1.3)

Manually installing incompatible versions is known to cause hard-to-debug issues.

It probably needs a complete rework to resolve this issue. The question then is whether it should be based on react-scripts which has not been updated since September 2022.

@MikeMcC399 MikeMcC399 closed this May 11, 2023
@MikeMcC399 MikeMcC399 deleted the update/puppeteer branch May 11, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants