New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject callbacks on socket close with Error #538

Merged

cyrus-and merged 3 commits into cyrus-and:master from nikolai-at-brightdata:origin

Jul 29, 2023

Contributor

nikolai-at-brightdata commented Jul 28, 2023

Using true for first argument is expected for ProtocolError, which is not the case

nikolai-at-brightdata and others added 3 commits

July 28, 2023 10:30


          Reject callbacks on socket close with Error

870db22

Using true for first argument is expected for ProtocolError,
which is not the case


          Enforce naming conventions

c6e3da6


          Adjust tests accordingly

1ae1e8f

cyrus-and merged commit 1eccd22 into cyrus-and:master

1 check passed

Owner

cyrus-and commented Jul 29, 2023

Thanks, well spotted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment