Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix write unraisable followed by interpretter shutdown #6089

Merged
merged 1 commit into from
May 21, 2024

Conversation

da-woods
Copy link
Contributor

I'm not 100% sure what causes the error, but I think it's that _PyErr_PrintEx stashes away some illicit references to invalid objects on sys.last_exc.

There's no reason to do this, so just do the print without the stash.

Fixes #6022

I'm not 100% sure what causes the error, but I think it's
that _PyErr_PrintEx stashes away some illicit references to
invalid objects on sys.last_exc.

There's no reason to do this, so just do the print without the
stash.

Fixes cython#6022
@da-woods da-woods added this to the 3.0.10 milestone May 21, 2024
@da-woods da-woods merged commit cd5a967 into cython:master May 21, 2024
64 checks passed
@da-woods da-woods deleted the fix-write-unraisable branch May 21, 2024 16:27
da-woods added a commit that referenced this pull request May 21, 2024
I'm not 100% sure what causes the error, but I think it's
that _PyErr_PrintEx stashes away some illicit references to
invalid objects on sys.last_exc.

There's no reason to do this, so just do the print without the
stash.

Fixes #6022
@da-woods
Copy link
Contributor Author

3.0.x commit 701e751

@da-woods da-woods modified the milestones: 3.0.10, 3.0.11 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Segfault when __dealloc__ calls a non-existent method.
1 participant