Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore the profile directive on 3.12 and above. #6125

Open
wants to merge 2 commits into
base: 0.29.x
Choose a base branch
from

Conversation

tvalentyn
Copy link

No description provided.

@scoder
Copy link
Contributor

scoder commented Apr 3, 2024 via email

@tvalentyn
Copy link
Author

Ah, yes of course. PTAL.

@tvalentyn tvalentyn marked this pull request as ready for review April 3, 2024 22:25
@tvalentyn
Copy link
Author

Failures in the prior CI run appear unrelated: https://github.com/cython/cython/actions/runs/8542813488/job/23407808172?pr=6125

@da-woods
Copy link
Contributor

da-woods commented Apr 7, 2024

So this basically looks good to be but:

  1. The tests turn out to be not running at all on Python 3.12 because it's marked as an allowed failure, and because the runtests.py uses import imp. I've created [0.29.x] Fix Python 3.12 tests #6135 to fix that.
  2. I'm a bit suspicious of the other test passes, because they run about 6 times faster than for Cython 3. (I don't think we've made the code-generation hugely slower since then so it suggests things aren't running properly)

I'd at least like to resolve the Python 3.12 situation and retest this I think.

@tvalentyn
Copy link
Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants