Implement PEP-669 sys.monitoring support #6144

scoder · 2024-04-17T20:21:14Z

Uses the PyMonitoring C-API that is being developed for Py3.13.

See https://docs.python.org/3/library/sys.monitoring.html
See python/cpython#111997
See python/cpython#116413

… on Python 3.12, not later.

This needs to be done after initialising the scope since we need to know the local scope to correctly include args and kwargs.

…13 (not only PyPy).

…Python versions since it was never actually used.

This was previously always off because it incorrectly reversed the "lookup_module_cpdef" option.

… underlying implementation function but do not re-initialise the trace so that both run in the same monitoring context.

…p header.

…ing.

… code overhead.

…pdef wrappers, and generator def/body. The code object is now owned by the innermost tree node (wrapper/gbody/etc.) and used by the outer syntax node (lambda, generator expression, function).

…ects independently (because they are really separate functions in the same code section).

…ree)

…ow always treat them as constant and just make sure they have their result code set up.

… wrapper.

…the generator body (instead of the other way round) since the body has a different signature.

Implement PEP-669 sys.monitoring support.

2d4374d

scoder added feature Code Generation labels Apr 17, 2024

scoder added 9 commits April 18, 2024 09:07

Fix macro signatures and add missing dummy macros.

68648bc

Fix long lines.

7edef77

Test runner: Use tag instead of >version to exclude pstats tests only…

db03c44

… on Python 3.12, not later.

Re-add dummy macro in Py3.12.

ddfa12b

Make macro implementation safer.

691d17c

Start implementing generator tracing.

b43394e

Fix compilation.

b863fc7

Trace coroutine resumes as function start in non-monitoring Python.

99af453

Fix code object creation for Lambda nodes.

a9a280e

This needs to be done after initialising the scope since we need to know the local scope to correctly include args and kwargs.

scoder mentioned this pull request Apr 26, 2024

Add code object to LambdaNode; fix for gen. expr. #6046

Closed

scoder added 17 commits April 26, 2024 19:23

Disable coverage/tracing tests in Py3.12.

7eabd35

Fix fallback declaration.

b3697c1

Generally disable monitoring/tracing tests in non-CPython before Py3.…

6fa7e70

…13 (not only PyPy).

Implement monitoring for generators and fix return value reporting.

71607ec

Implement exception monitoring and remove the code in pre-monitoring …

078cce0

…Python versions since it was never actually used.

Fix 'skip_dispatch' condition for module level cpdef functions.

219db5f

This was previously always off because it incorrectly reversed the "lookup_module_cpdef" option.

Remove duplicate test code.

70ddc4d

Move import into doctest.

fb6373a

Let the Python cpdef wrapper function use the same code object as the…

b65ac1c

… underlying implementation function but do not re-initialise the trace so that both run in the same monitoring context.

Fix 'return' tracing when only 'linetrace' is enabled.

151e12c

Add Python comparison test to "line_trace" test.

4ec2249

Do not issue start/line/return events from cpdef wrapper.

30882a7

Do not generate dead code in Python cpdef wrapper.

e8ff7c3

Enable line tracing for 'pass' statements.

e49c5b8

Implement line monitoring, including repeated line events for the loo…

b1caa7e

…p header.

Delete test that is now invalid.

caa5db0

Fix PassStatNode replacement.

b4aeec4

scoder added 16 commits April 30, 2024 14:28

Make "line_trace" test failures easier to understand.

9079fc8

Undo accidentally committed changes.

e1ab3ff

Re-add Return tracing in the exception case for pre-monitoring profil…

b38edbe

…ing.

Improve test output.

6fcea7f

Extract common code from __Pyx_TraceLine() macro to reduce the inline…

ab42d90

… code overhead.

Fix some code issues with generators.

6867197

Clean up the ownership of code objects between functions, their def/c…

29039bc

…pdef wrappers, and generator def/body. The code object is now owned by the innermost tree node (wrapper/gbody/etc.) and used by the outer syntax node (lambda, generator expression, function).

Extend the generator monitoring tests.

b420e19

Initial attempts to monitor fused functions and set up their code obj…

785060c

…ects independently (because they are really separate functions in the same code section).

Properly apply declaration analysis to code objects.

3508eb9

Improve test name output by including the file extension (py/pyx/srct…

ade0107

…ree)

Fix crash in error case due to invalid tree structure.

8f9898e

Clean up various issues with missing or mishandled code objects. We n…

4060977

…ow always treat them as constant and just make sure they have their result code set up.

Use correct code object for fused wrapper functions.

aabdaab

Give all CFuncDefNodes a CodeObjectNode, not just those with a Python…

eafaeb0

… wrapper.

Use the code object of the (user facing) generator function also for …

c14e483

…the generator body (instead of the other way round) since the body has a different signature.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement PEP-669 sys.monitoring support #6144

Implement PEP-669 sys.monitoring support #6144

scoder commented Apr 17, 2024

Implement PEP-669 sys.monitoring support #6144

Are you sure you want to change the base?

Implement PEP-669 sys.monitoring support #6144

Conversation

scoder commented Apr 17, 2024