Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operator-equal operators #6197

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erik-whiting
Copy link

Hello Cython community. I wanted to take a stab at this issue as it looks like it hasn't ben addressed yet. Hoping the build CI passes and if not someone can point me in the right direction perhaps? Tried running tests locally but got a syntax error from Shadow.py

@da-woods
Copy link
Contributor

Doesn't look like the CI passes unfortunately.

I think the trick to running the tests locally is not even to try to install Cython. Just change directory to wherever the Cython git repo is and do python3 runtests.py whatever. That should use the version you have checked out rather that whatever you have installed.

@erik-whiting
Copy link
Author

Doesn't look like the CI passes unfortunately.

I think the trick to running the tests locally is not even to try to install Cython. Just change directory to wherever the Cython git repo is and do python3 runtests.py whatever. That should use the version you have checked out rather that whatever you have installed.

thanks! I will try that. I did see the CI failed, I have been looking at it but will not be able to do a deep dive on it until this weekend. My guess is that I need to add support for the operators in some of the files in Cython/Includes/libcpp directory. That is my guess anyway and where I'll start first. This is my first submission to Cython so it will take me a while to get the PR right, but I'm on it 🫡

@erik-whiting erik-whiting marked this pull request as draft May 17, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants