Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add note on origins w/ default port to README.md #163

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+3 −1
Open

add note on origins w/ default port to README.md #163

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c983e70
Allow specifying redundant default port in origin
nbr Apr 4, 2018
4e536ff
Remove default port from http(s) without URI#parse
nbr Jun 13, 2018
40f3fed
revert code changes
nbr Aug 2, 2022
96db63b
Merge remote-tracking branch 'upstream/master'
nbr Aug 2, 2022
897cd5f
add note on origins w/ default port to README.md
nbr Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Expand Up @@ -111,7 +111,9 @@ A Resource path can be specified as exact string match (`/path/to/file.txt`) or

### Origin Matching

When specifying an origin, make sure that it does not have a trailing slash.
* When specifying an origin, make sure that it does not have a trailing slash.

* When specifying an HTTP origin that uses the scheme's default port (e.g. `http://example.test:80`), some clients may not strip the port which could result in unexpected blocked requests (additional context [here](https://github.com/request/request/pull/2904)).

### Testing Postman and/or cURL

Expand Down