Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for text inputs losing focus when table w/ resizable column unmounts #425

Merged
merged 2 commits into from Oct 28, 2019
Merged

Fix for text inputs losing focus when table w/ resizable column unmounts #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12d3e8e
fix(table): uses a workaround to address a react-draggable bug
mperrotti Oct 28, 2019
ff8bc01
Merge branch 'master' into mp/fix/react-draggable-unfocuses-inputs
mperrotti Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 3 additions & 15 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -52,7 +52,7 @@
"react-chartist": "^0.13.3",
"react-click-outside": "3.0.1",
"react-delegate-component": "1.0.0",
"react-draggable": "3.2.1",
"react-draggable": "3.3.2",
"react-emotion": "9.2.12",
"react-focus-lock": "2.0.5",
"react-tabs": "^3.0.0",
Expand Down
3 changes: 3 additions & 0 deletions packages/table/components/Table.tsx
View file
Open in desktop
Expand Up @@ -469,6 +469,9 @@ export class Table<T> extends React.PureComponent<TableProps, TableState> {
this.getContainerWidth() * (1 - COL_RESIZE_MAX_WIDTH),
bottom: 0
}}
// Needed for an issue where text inputs lose focus when a Draggable unmounts
// Github issue: https://github.com/mzabriskie/react-draggable/issues/315
enableUserSelectHack={false}
>
<div>
<div
Expand Down