forceRadial x, y and angle accessors #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the radial force...
d3.forceRadial(radius[, x][, y])
... allows only numbers to the `x` and `y` positions:
> If x is specified, sets the x-coordinate of the circle center to the specified number and returns this force.
This proposed change allows passing functions to `radial.x()` and `radial.y()`, using the same pattern of other forces. Here is the working demo: https://bl.ocks.org/anonymous/0685343afe4675a022403be8728bc7c4/7dda06727201c128b9ff820b24c2c955e655436d
This was referenced Jul 6, 2020
|
I don't see that this feature got into d3 or am I wrong? |
|
Thanks for you interest. No the feature didn't make it into D3@6. I think it should be published it as a stand-alone plugin or module at some point, but I haven't had much time recently. The code is simple enough to copy/paste, maybe it just needs a good example? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #113 (by @GerardoFurtado), and fixes #152
demonstration https://observablehq.com/d/9187c989f882beee
PS: It's a breaking change since the force.x() returns an accessor function not a value.