Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forceRadial x, y and angle accessors #167

Merged
merged 3 commits into from
Jul 28, 2020
Merged

forceRadial x, y and angle accessors #167

merged 3 commits into from
Jul 28, 2020

Commits on Jul 6, 2020

  1. Passing functions to radial.x() and radial.y() 

    Currently, the radial force...

    d3.forceRadial(radius[, x][, y])

... allows only numbers to the `x` and `y` positions:

> If x is specified, sets the x-coordinate of the circle center to the specified number and returns this force.

This proposed change allows passing functions to `radial.x()` and `radial.y()`, using the same pattern of other forces. Here is the working demo: https://bl.ocks.org/anonymous/0685343afe4675a022403be8728bc7c4/7dda06727201c128b9ff820b24c2c955e655436d
    @GerardoFurtado @Fil
    GerardoFurtado authored and Fil committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    dcd12d2 View commit details
    Browse the repository at this point in the history

  2. document forceRadial.x() and .y() as setting accessor functions inste… 

    …ad of numbers
    @Fil
    Fil committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    795ba31 View commit details
    Browse the repository at this point in the history

  3. forceRadial().angle() sets the preferred angle 

    as in https://observablehq.com/@fil/forcepolar
closes #152
    @Fil
    Fil committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    ba02525 View commit details
    Browse the repository at this point in the history