Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix d3-time example #3750

Merged
merged 1 commit into from Aug 21, 2023
Merged

Fix d3-time example #3750

merged 1 commit into from Aug 21, 2023

Conversation

kmandov
Copy link
Contributor

@kmandov kmandov commented Aug 9, 2023

  • Add missing date arguments to d3.timeMonth.floor() and d3.timeMonth.ceil() calls.
  • Fix the expected date range

mbostock
mbostock approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mbostock mbostock enabled auto-merge (squash) August 21, 2023 18:07
@kmandov
Copy link
Contributor Author

kmandov commented Aug 21, 2023

Thank YOU! 😊 🙏

@mbostock mbostock merged commit fa4553c into d3:main Aug 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock mbostock approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kmandov @mbostock