Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Typo in README is corrected #3811

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Typo in README is corrected #3811

wants to merge 1 commit into from

Conversation

codesmith-emmy
Copy link

No description provided.

mbostock
mbostock reviewed Mar 12, 2024
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s not a typo, but I agree it’s a little awkward. For more than a decade,

  • D3 has powered groundbreaking and award-winning visualizations
  • D3 has become a foundational building block
  • D3 has fostered a vibrant community

Though maybe it should say “has been a foundational building block” rather than “has become a foundational building block”?

@codesmith-emmy
Copy link
Author

Took a closer look at the sentence again after reading your comment and I have to agree it’s not a typo. This is totally a mistake on my part.

I think “has become a foundational building block” is very much in order and should be left that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock mbostock left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codesmith-emmy @mbostock