feat: add goroutine watcher #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jake-shin0
commented
Apr 24, 2024
| @@ -53,8 +64,9 @@ type autoPprof struct { | |||
| reportBoth bool | |||
There was a problem hiding this comment.
This field is an option that is only valid when monitoring only two things, CPU and memory, and as the runtime monitor increases, its meaning becomes less meaningful.
@mingrammer Please give me your opinion on how to remove it in a separate version!
jake-shin0
changed the title
dlsrb6342
reviewed
Apr 25, 2024
| @@ -858,13 +1020,13 @@ func BenchmarkLightJob(b *testing.B) { | |||
|
|
|||
| func BenchmarkLightJobWithWatchCPUUsage(b *testing.B) { | |||
There was a problem hiding this comment.
i think we need to benckmark goroutine watcher too.
There was a problem hiding this comment.
I artificially created a lot of goroutines and ran a benchmark test. This is my first time doing a test like this. What should I fix?
BenchmarkLightAsyncJob-5 376760 32056 ns/op 7040 B/op 352 allocs/op
BenchmarkLightAsyncJobWithWatchGoroutineCount-5 350994 33689 ns/op 7040 B/op 351 allocs/op
BenchmarkHeavyAsyncJob-5 414 29095456 ns/op 6001969 B/op 300096 allocs/op
BenchmarkHeavyAsyncJobWithWatchGoroutineCount-5 403 29474789 ns/op 5972177 B/op 298607 allocs/op
suripark
approved these changes
Apr 26, 2024
| return err | ||
| } | ||
|
|
||
| runtimeQryer, err := queryer.NewRuntimeQueryer() |
| func (s *SlackReporter) ReportGoroutineProfile( | ||
| ctx context.Context, r io.Reader, gi GoroutineInfo, | ||
| ) error { | ||
| hostname, _ := os.Hostname() // Don't care about this error. |
There was a problem hiding this comment.
p999; I think this comment is vague, how about just removing it?
| } | ||
| var ( | ||
| sm = stat.Memory | ||
| usage = sm.Usage.Usage - sm.InactiveFile |
| return 0, nil | ||
| } | ||
|
|
||
| s1, s2 := c.q.head(), c.q.tail() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
queryerwas managed as a separate dir and its implementation was divided. (cgroup & runtime)Queryerinterface method to public.queryer, I also wanted to manageprofilerin dir, but I did not consider this part.queryerandprofiler, but did not do so.ticker, so pprof lib is used in bothqueryerandprofiler.