Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for redisStore(url) #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

llwt
Copy link

@llwt llwt commented Jan 6, 2018

Taken from this fork: davb@d27dd8b

@dabroek
Copy link
Owner

dabroek commented Feb 13, 2018

Actually, this would be to support redisStore(url). Could you give more context on how this is used?

@llwt
Copy link
Author

llwt commented Feb 14, 2018

We use redis config url string rather than config objects in our configs. We are currently doing a bit of extra processing to support the config for this lib.

Right now we do this:

parseRedisUrl is the parse function extracted from ioredis

cacheManager.caching({
  ...parseRedisUrl(config.redisCacheConfig.url),
  store: require('cache-manager-ioredis'),
  ttl: config.redisCacheConfig.ttl,
}),

If this was merged we could do the following and remove the parseRedisUrl fn:

cacheManager.caching({
  url: config.redisCacheConfig.url,
  store: require('cache-manager-ioredis'),
  ttl: config.redisCacheConfig.ttl,
})

@llwt
Copy link
Author

llwt commented Mar 6, 2018

@dabroek Have you had a chance to look at this by chance?

@soanvig
Copy link

soanvig commented Oct 18, 2021

+1 for that functionality

@dmtar
Copy link

dmtar commented Oct 27, 2021

+1 Can you review that?

@llwt llwt changed the title support for redisStore({url}) support for redisStore(url) Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants