Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom redis client #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tobyhinloopen
Copy link

@tobyhinloopen tobyhinloopen commented Oct 9, 2020

Closes #17

Basically allows you to pass an existing redis client instead of passing host, pass, etc.

client: Redis.createClient()

Please review @dabroek . Change suggestions are welcome. I'm not sure how to thoroughly test my change without just copying all tests.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 96.098% when pulling 39e62f2 on Hockeybond:17-allow-custom-client into ecbfb29 on dabroek:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 96.098% when pulling 39e62f2 on Hockeybond:17-allow-custom-client into ecbfb29 on dabroek:master.

@gfzabarino
Copy link

Is there a reason why this isn't getting merged?

@felinto-dev
Copy link

felinto-dev commented Apr 12, 2021

Excellent! It was exactly what I am looking for.

@tobyhinloopen could you provide minimal documentation on how I can pass a REDIS connection URI instead AUTH, PORT, etc. ?
I would use Heroku REDIS Cache. I believe that this is a common use case.

@tobyhinloopen
Copy link
Author

I think this isn't being merged because IIRC it doesn't actually work. You need a separate Redis connection and it will consume/lock the connection. If you reuse the connection, it will no longer function for other users of the connection.

Disclaimer: It has been a while, I forgot the actual details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing redis client instance instead of host, port, auth_pass etc…
6 participants