cli: allow calling core functions directly #7310
Draft
+448
−353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helderco
force-pushed
the
helder/oss-192-allow-calling-core-functions-from-the-cli
branch
from
ea1d2ce
to
797666b
Compare
helderco
force-pushed
the
helder/oss-192-allow-calling-core-functions-from-the-cli
branch
from
797666b
to
27589db
Compare
Most common reason for not being able to call a function is unsupported flags, but if there's unsupported return types as well, they should be added too. This change excludes functions with **any** unsupported flag, however, maybe it’s best to do it only for required flags, and keep the function but skip adding the optional arguments that aren’t supported. Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
This removes `sync` as a default selection for commands ending in a `Container`, `Directory` or `File`. Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
The `--help` flag is now global (interspersed). So the help will no longer be shown next to the command where it’s defined if there’s more to the right. It’s position in the chain no longer matters, it will be the same as adding it to the end. This was needed to look ahead and skip some validations while that flag wasn’t parsed yet, and while it was possible to preserve the previous behavior, making it global seems more consistent with CLI conventions, besides being simpler. There's also some refactoring to make the logic easier to follow and encapsulate some responsibilities better in functions. Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com> # Conflicts: # cmd/dagger/functions.go # cmd/dagger/module.go
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
helderco
force-pushed
the
helder/oss-192-allow-calling-core-functions-from-the-cli
branch
from
27589db
to
babaf87
Compare
|
Update: based on discussion in #6947, will need to make some changes: - dagger -m- container
+ dagger -m containerWill check if what's in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6947
Warning
This is based on other PRs so they can all be tested here together, but they need to be merged first, especially #7417. They're in their own commits so it's easier to review just the last one:
--help#7417Can be run from anywhere as it doesn't require a module to load:
Todo
-m(currently:-)--help#7417