WIP refactor of server/sessions/buildkit-interfaces #7315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 10, 2024
|
Ended up spinning out the support for serving nested execs from the executor here (ended up just becoming removal of the shim entirely). Coming back here now to finish up the rest of this refactor on top of that. |
sipsma
force-pushed
the
refactor-server-and-bk
branch
from
0c9a335
to
0c8f915
Compare
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
sipsma
force-pushed
the
refactor-server-and-bk
branch
from
0c8f915
to
1878470
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another part of the effort to support #6916 while also doing general cruft cleanup and setup for various upcoming efforts.
Deeply WIP still, but main goal is to fix the current knots tied between
BuildkitController,DaggerServer,BuildkitClient,Query,dagql.Server,ClientCall-related stuff, etc. in order to make the whole system more comprehensible and make it easy to manage/isolate state (both now and going forward).There's quite a bit of consolidation of those objects (a number of them just don't even exist any more), a lot more robust/clear handling of synchronization + state management, etc.
Mostly sending out because I'm starting to get curious what the diff is shaping up to look like, but if you want to check it out, the new implementation of the
engine/serverpackage is currently inengine/newserver