docs: Create multi-language custom types page #7340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikram-dagger
commented
May 9, 2024
vikram-dagger
force-pushed
the
docs-244-migrate-custom-types
branch
from
05456c2
to
6711200
Compare
helderco
reviewed
May 13, 2024
helderco
reviewed
May 13, 2024
docs/current_docs/manuals/developer/snippets/custom-types/typescript/src/index.ts
Outdated
Show resolved
Hide resolved
|
I moved the snippets into paths that match the default location on cd snippets/custom-types/typescript
dagger init --sdk=typescript --source=. --name=github
dagger call dagger-organization members url |
I don't think we should make this change in the current PR, as this structure is not currently followed for other snippets and so it will create an inconsistency. I agree that we should do this in general, but I would prefer to do it globally for all snippets in a separate PR. Opened #7372 |
Signed-off-by: Vikram Vaswani <vikram@dagger.io>
Signed-off-by: Vikram Vaswani <vikram@dagger.io>
Signed-off-by: Vikram Vaswani <vikram@dagger.io>
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
vikram-dagger
force-pushed
the
docs-244-migrate-custom-types
branch
from
3976bf6
to
41c99b7
Compare
Signed-off-by: Vikram Vaswani <vikram@dagger.io>
Signed-off-by: Vikram Vaswani <vikram@dagger.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.