Start removing mage 🎉 #7349
Merged
Start removing mage 🎉 #7349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedevc
force-pushed
the
start-mage-removal
branch
7 times, most recently
from
12f4efd
to
de5412e
Compare
jedevc
force-pushed
the
start-mage-removal
branch
from
de5412e
to
a9720fa
Compare
jedevc
force-pushed
the
start-mage-removal
branch
2 times, most recently
from
a7e8455
to
4209693
Compare
|
Picking this up now since I have some related changes coming up and it would be best to have this merged before then. |
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
start-mage-removal
branch
from
4209693
to
02731ab
Compare
Signed-off-by: Justin Chadwell <me@jedevc.com>
|
Rebased, and also realized that we had missed bumping every runner in the last "improving release" PR - specifically the release job was still using v0.11.2. |
gerhard
force-pushed
the
start-mage-removal
branch
from
cc8a581
to
d1f46b9
Compare
Also, call the arguments what they are: functions, FTW! Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
No, not even when running with race. Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
gerhard
force-pushed
the
start-mage-removal
branch
from
a27def3
to
28fd975
Compare
gerhard
approved these changes
May 14, 2024
There was a problem hiding this comment.
This now looks good to me!
If you agree with the changes @jedevc, it's OK to merge as soon as all checks pass. We can follow-up with improvements 💪
Related:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the first step to removing mage from our CI - unfortunately, to do the whole thing is still a little tricky right now.
There are several parts:
dagger callinstead ofhack/make.hack/makeis removed! All CI jobs that still use it, now directly callgo run.engine:dev, used for./hack/dev. Eventually, this should be replaced by ci: use nested dagger for testdev #7223.engine:publish, used during github publishing. This connects the cli+engine publishing together, and ensures that the cli parts are all bumped. This is trickier to remove - we'd want to make our_hack_make.ymlscript an action, instead of a workflow - then, we can connect it through to other actions.Note! This PR changes some workflows on main, which don't run in a PR - so there is a chance that these workflows might fail when merged.