Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk/typescript): rename typescript sdk runtime name #7355

Merged
merged 2 commits into from May 14, 2024

Conversation

wingyplus
Copy link
Contributor

Found during working on #6967. The name in
sdk/typescript/runtime/dagger.json use PascalCase as a name but other SDK use kebab-case. This commit try renaming it to kebab-case to make it consistent.

Found during working on dagger#6967. The `name` in
`sdk/typescript/runtime/dagger.json` use PascalCase as a name but other
SDK use kebab-case. This commit try renaming it to kebab-case to make it
consistent.

Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
@helderco helderco force-pushed the rename-typescript-runtime-name branch from 9f2af97 to e46bdf7 Compare May 10, 2024 17:15
@helderco
Copy link
Contributor

I've seen someone report this somewhere. 🤔

Just waiting for checks to pass. 🙂

@helderco
Copy link
Contributor

You may need to rename the struct name in the module:

-TypeScriptSdk
+TypescriptSdk

Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
@wingyplus
Copy link
Contributor Author

You may need to rename the struct name in the module:

-TypeScriptSdk
+TypescriptSdk

I forgot about it. T_T

Fixed.

@wingyplus
Copy link
Contributor Author

Found Python test failed

2024-04-20T06:20:55.1921411Z �[95m15: �[0m=== RUN   TestModulePythonLockHashes/pip
2024-04-20T06:20:55.1924054Z �[95m15: �[0m    module_python_test.go:708: 
2024-04-20T06:20:55.1924686Z �[95m15: �[0m        	Error Trace:	/app/core/integration/module_python_test.go:708
2024-04-20T06:20:55.1944640Z �[95m15: �[0m        	Error:      	Error "input: container.from.withMountedFile.withWorkdir.withExec.withNewFile.withNewFile.withExec.sync resolve: process \"dagger --debug develop\" did not complete successfully: exit code: 1\n\nStderr:\n\x1b[95m1: \x1b[0m\x1b[36min \x1b[0mdagger --debug develop\n\x1b[95m1: \x1b[0mError: failed to get module SDK: input: moduleSource.withContextDirectory.asModule resolve: failed to create module: select: failed to update codegen and runtime: failed to generate code: failed to call sdk module codegen: select: call function \"Codegen\": process \"/runtime\" did not complete successfully: exit code: 2\n\x1b[95m1: \x1b[0mStdout:\n\x1b[95m1: \x1b[0mmarshal: json: error calling MarshalJSON for type *dagger.GeneratedCode: input: container.from.withEnvVariable.withEnvVariable.withEnvVariable.withEnvVariable.withMountedCache.withDefaultTerminalCmd.withWorkdir.withFile.withMountedDirectory.withWorkdir.withExec.withNewFile.withExec.file resolve: failed to compute cache key: failed to get state for index 0 on copy /runtime/template/runtime.py /runtime\n\n\x1b[2m06:20:46\x1b[0m DBG frontend exporting \x1b[2mspans=\x1b[0m1\n\x1b[2m06:20:46\x1b[0m DBG frontend exporting span \x1b[2mtrace=\x1b[0m7b836ea21f0bffa1417574997fd064bb \x1b[2mid=\x1b[0m5e8b79744a42032a \x1b[2mparent=\x1b[0m0124736fe0f11def \x1b[2mspan=\x1b[0m\"dagger --debug develop\"\n\x1b[2m06:20:46\x1b[0m DBG recording span \x1b[2mspan=\x1b[0m\"dagger --debug develop\" \x1b[2mid=\x1b[0m5e8b79744a42032a\n\x1b[2m06:20:46\x1b[0m DBG recording span child \x1b[2mspan=\x1b[0m\"dagger --debug develop\" \x1b[2mparent=\x1b[0m0124736fe0f11def \x1b[2mchild=\x1b[0m5e8b79744a42032a\n\x1b[2m06:20:47\x1b[0m DBG frontend exporting \x1b[2mspans=\x1b[0m1\n\x1b[2m06:20:47\x1b[0m DBG frontend exporting span \x1b[2mtrace=\x1b[0m7b836ea21f0bffa1417574997fd064bb \x1b[2mid=\x1b[0m5e8b79744a42032a \x1b[2mparent=\x1b[0m0124736fe0f11def \x1b[2mspan=\x1b[0m\"dagger --debug develop\"\n\x1b[2m06:20:47\x1b[0m DBG new end \x1b[2mold=\x1b[0m\"0001-01-01 00:00:00 +0000 UTC\" \x1b[2mnew=\x1b[0m\"2024-04-20 06:20:47.837753606 +0000 UTC\"\n\x1b[2m06:20:47\x1b[0m DBG recording span \x1b[2mspan=\x1b[0m\"dagger --debug develop\" \x1b[2mid=\x1b[0m5e8b79744a42032a\n\x1b[2m06:20:47\x1b[0m DBG recording span child \x1b[2mspan=\x1b[0m\"dagger --debug develop\" \x1b[2mparent=\x1b[0m0124736fe0f11def \x1b[2mchild=\x1b[0m5e8b79744a42032a\n\x1b[2m06:20:47\x1b[0m DBG frontend exporting logs \x1b[2mlogs=\x1b[0m1\n\x1b[2m06:20:47\x1b[0m DBG exporting log \x1b[2mspan=\x1b[0m5e8b79744a42032a \x1b[2mbody=\x1b[0m\"Error: failed to get module SDK: input: moduleSource.withContextDirectory.asModule resolve: failed to create module: select: failed to update codegen and runtime: failed to generate code: failed to call sdk module codegen: select: call function \\\"Codegen\\\": process \\\"/runtime\\\" did not complete successfully: exit code: 2\\n\\nStdout:\\nmarshal: json: error calling MarshalJSON for type *dagger.GeneratedCode: input: container.from.withEnvVariable.withEnvVariable.withEnvVariable.withEnvVariable.withMountedCache.withDefaultTerminalCmd.withWorkdir.withFile.withMountedDirectory.withWorkdir.withExec.withNewFile.withExec.file resolve: failed to compute cache key: failed to get state for index 0 on copy /runtime/template/runtime.py /runtime\\n\"\n\nError: failed to get module SDK: input: moduleSource.withContextDirectory.asModule resolve: failed to create module: select: failed to update codegen and runtime: failed to generate code: failed to call sdk module codegen: select: call function \"Codegen\": process \"/runtime\" did not complete successf\x1b[0m\nully: exit code: 2                                                                                                                                                                                                                                                                                          \x1b[0m\n  
2024-04-20T06:20:55.1968774Z �[95m15: �[0m                                                                                                                                                                                                                                                                                                          \x1b[0m\nStdout:                                                                                                                                                                                                                                                                                                     \x1b[0m\nmarshal: json: error calling MarshalJSON for type *dagger.GeneratedCode: input: container.from.withEnvVariable.withEnvVariable.withEnvVariable.withEnvVariable.withMountedCache.withDefaultTerminalCmd.withWorkdir.withFile.withMountedDirectory.withWorkdir.withExec.withNewFile.withExec.file resolve: fai\x1b[0m\nled to compute cache key: failed to get state for index 0 on copy /runtime/template/runtime.py /runtime                                                                                                                                                                                                     \x1b[0m\n\nError: failed to get module SDK: input: moduleSource.withContextDirectory.asModule resolve: failed to create module: select: failed to update codegen and runtime: failed to generate code: failed to call sdk module codegen: select: call function \"Codegen\": process \"/runtime\" did not complete successfully: exit code: 2\n\nStdout:\nmarshal: json: error calling MarshalJSON for type *dagger.GeneratedCode: input: container.from.withEnvVariable.withEnvVariable.withEnvVariable.withEnvVariable.withMountedCache.withDefaultTerminalCmd.withWorkdir.withFile.withMountedDirectory.withWorkdir.withExec.withNewFile.withExec.file resolve: failed to compute cache key: failed to get state for index 0 on copy /runtime/template/runtime.py /runtime" does not contain "DO NOT MATCH THE HASHES"
2024-04-20T06:20:55.1975546Z �[95m15: �[0m        	Test:       	TestModulePythonLockHashes/pip
2024-04-20T06:20:55.1976108Z �[95m15: �[0m--- FAIL: TestModulePythonLockHashes/pip (2.08s)
2024-04-20T06:20:55.1976757Z �[95m15: �[0m�[31mFAIL�[0m core/integration.TestModulePythonLockHashes/pip (2.08s)

@wingyplus
Copy link
Contributor Author

I've seen someone report this somewhere. 🤔

Maybe it is #6967 (comment). :)

@gerhard gerhard merged commit e25ff72 into dagger:main May 14, 2024
63 checks passed
@wingyplus wingyplus deleted the rename-typescript-runtime-name branch May 14, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants