New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sdk/typescript): rename typescript sdk runtime name #7355
Merged
gerhard
merged 2 commits into
dagger:main
from
wingyplus:rename-typescript-runtime-name
May 14, 2024
Merged
chore(sdk/typescript): rename typescript sdk runtime name #7355
gerhard
merged 2 commits into
dagger:main
from
wingyplus:rename-typescript-runtime-name
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found during working on dagger#6967. The `name` in `sdk/typescript/runtime/dagger.json` use PascalCase as a name but other SDK use kebab-case. This commit try renaming it to kebab-case to make it consistent. Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
helderco
force-pushed
the
rename-typescript-runtime-name
branch
from
May 10, 2024 17:15
9f2af97
to
e46bdf7
Compare
I've seen someone report this somewhere. 🤔 Just waiting for checks to pass. 🙂 |
You may need to rename the struct name in the module: -TypeScriptSdk
+TypescriptSdk |
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
I forgot about it. T_T Fixed. |
Found Python test failed
|
Maybe it is #6967 (comment). :) |
helderco
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found during working on #6967. The
name
insdk/typescript/runtime/dagger.json
use PascalCase as a name but other SDK use kebab-case. This commit try renaming it to kebab-case to make it consistent.