Alert section for freshness checks #21676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
docs/content/concepts/assets/asset-checks/checking-for-data-freshness.mdx
Outdated
Show resolved
Hide resolved
docs/content/concepts/assets/asset-checks/checking-for-data-freshness.mdx
Outdated
Show resolved
Hide resolved
docs/content/concepts/assets/asset-checks/checking-for-data-freshness.mdx
Outdated
Show resolved
Hide resolved
docs/content/concepts/assets/asset-checks/checking-for-data-freshness.mdx
Outdated
Show resolved
Hide resolved
docs/content/concepts/assets/asset-checks/checking-for-data-freshness.mdx
Outdated
Show resolved
Hide resolved
docs/content/concepts/assets/asset-checks/checking-for-data-freshness.mdx
Outdated
Show resolved
Hide resolved
dpeng817
force-pushed
the
dpeng817/alert_section_freshness_docs
branch
from
5b487f9
to
e316d9e
Compare
docs/content/concepts/assets/asset-checks/checking-for-data-freshness.mdx
Outdated
Show resolved
Hide resolved
docs/content/concepts/assets/asset-checks/checking-for-data-freshness.mdx
Outdated
Show resolved
Hide resolved
dpeng817
force-pushed
the
dpeng817/alert_section_freshness_docs
branch
from
e316d9e
to
dd26305
Compare
sryza
approved these changes
May 15, 2024
erinkcochran87
approved these changes
May 15, 2024
docs/content/concepts/assets/asset-checks/checking-for-data-freshness.mdx
Outdated
Show resolved
Hide resolved
docs/content/concepts/assets/asset-checks/checking-for-data-freshness.mdx
Outdated
Show resolved
Hide resolved
@sryza Which asset check page - this main category one, or this guide for defining checks? What's the thinking behind moving it? |
I honestly didn't think that far - I could see either, or even a third one.
These instructions aren't really specific to freshness checks in particular. They apply for other asset checks as well. |
dpeng817
force-pushed
the
dpeng817/alert_section_freshness_docs
branch
from
dd26305
to
d6a4db7
Compare
…b.com/dagster-io/dagster into dpeng817/alert_section_freshness_docs
|
@dpeng817 Back to you - lmk what you think |
dpeng817
commented
May 15, 2024
dpeng817
commented
May 15, 2024
docs/content/concepts/assets/asset-checks/checking-for-data-freshness.mdx
Show resolved
Hide resolved
dpeng817
commented
May 15, 2024
There was a problem hiding this comment.
@erinkcochran87 a few small comments otherwise LGTM. Thanks for putting this together.
|
Just waiting for BK, then I'll merge this guy |
nikomancy
pushed a commit
that referenced
this pull request
May 22, 2024
Adds an alerts section to the freshness guide. I originally wanted to make more sweeping changes here, but it's proving more difficult than I thought. I think the biggest outstanding problem with the guide is thelack of reference to alerting (main important thing about freshness, so let's fix that first). --------- Co-authored-by: Erin Cochran <erin.k.cochran@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an alerts section to the freshness guide.
I originally wanted to make more sweeping changes here, but it's proving more difficult than I thought. I think the biggest outstanding problem with the guide is thelack of reference to alerting (main important thing about freshness, so let's fix that first).