feat(looker): represent looker views dependencies from substitution #21806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @rexledesma and the rest of your teammates on |
rexledesma
requested review from
clairelin135
and removed request for
clairelin135
This was referenced May 14, 2024
benpankow
approved these changes
May 14, 2024
python_modules/libraries/dagster-looker/dagster_looker/asset_decorator.py
Show resolved
Hide resolved
python_modules/libraries/dagster-looker/dagster_looker/asset_decorator.py
Outdated
Show resolved
Hide resolved
rexledesma
force-pushed
the
rl/parse-looker-subtitution-views-using-regex
branch
2 times, most recently
from
d25cdb2
to
056ace9
Compare
rexledesma
force-pushed
the
rl/parse-looker-subtitution-views-using-regex
branch
from
056ace9
to
549380a
Compare
Merge activity
|
alangenfeld
pushed a commit
that referenced
this pull request
May 14, 2024
…21806) ## Summary & Motivation Parse the Looker substitution syntax ($) using regex. See [https://cloud.google.com/looker/docs/sql-and-referring-to-lookml#substitution_operator_](https://cloud.google.com/looker/docs/sql-and-referring-to-lookml#substitution_operator_) for more details. This is similar to how dbt parses their jinja model templates. If raw, non-templated tables are included in the SQL alongside templated Looker views from Looker substitution, we will only provide the templated Looker views as upstream dependencies. For SQL definitions that only use non-templated tables, we will still parse them using `sqlglot`. And with SQL definitions that only use non-templated tables, but have [Liquid templating](https://cloud.google.com/looker/docs/liquid-variable-reference), no parsing will occur. ## How I Tested These Changes pytest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Parse the Looker substitution syntax ($) using regex. See https://cloud.google.com/looker/docs/sql-and-referring-to-lookml#substitution_operator_ for more details.
This is similar to how dbt parses their jinja model templates. If raw, non-templated tables are included in the SQL alongside templated Looker views from Looker substitution, we will only provide the templated Looker views as upstream dependencies.
For SQL definitions that only use non-templated tables, we will still parse them using
sqlglot.And with SQL definitions that only use non-templated tables, but have Liquid templating, no parsing will occur.
How I Tested These Changes
pytest