Add URL param to support parallel fetches in LiveDataProvider #21818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengotow
approved these changes
May 14, 2024
| return; | ||
| } | ||
| this.isFetching = true; | ||
| this.activeFetches += 1; |
There was a problem hiding this comment.
This seems good, but I wonder if we could make the feature flag split work across two threads instead of adding another concurrency abstraction?
There was a problem hiding this comment.
Yeah I was thinking that too originally but It's actually different behavior because "threads" are a concept exposed to product engineers in order to allow different sets of assets to not compete with each other for bandwidth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Add support for having multiple parallel threads fetching live data
How I Tested These Changes
loaded the app and saw parallel requests
jest