[bug] Fix issue causing ReconstructableJobs containing certain types of metadata to error #21819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Resolves: #21815
Note that while the test involved here is referencing
CacheableAssetsDefinition
, this same error would occur with regular assets. Any asset using aMetadataValue
which contains within it a mutable object (which would be table schema and table column lineage which contain lists I believe) would encounter a similar error.After switching the core
MetadataValue
class from aNamedTuple
to a pydantic model, the code we use to generate hashes for our serializable objects stopped handling them. This PR fixes this.How I Tested These Changes
After updating the test to include metadata of this type, observed the mentioned error. These changes resolved it.