Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use --no-deps when installing dagster reqs during docs build, use automock when building sphinx docs #5156

Closed
wants to merge 1 commit into from

Conversation

gibsondan
Copy link
Member

use --no-deps when installing dagster reqs during docs build, use automock when building sphinx docs

Summary:
This ended up being much more of a journey than I was hoping, and I'm not sure the cost is worth the benefit.

For reasons that are not clear to me, this new setup also surfaced more warnings that needed to be cleaned up.

…omock when building sphinx docs

Summary:
This ended up being much more of a journey than I was hoping, and I'm not sure the cost is worth the benefit.

For reasons that are not clear to me, this new setup also surfaced more warnings that needed to be cleaned up.
@vercel
Copy link

vercel bot commented Oct 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/elementl/dagster/JCfUHYf3vjSagVJvdPH2yZvwJSvB
✅ Preview: https://dagster-git-sphinxwarnings2-elementl.vercel.app

@gibsondan
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite and will continue to be automatically updated while this PR remains open.

@gibsondan
Copy link
Member Author

Filed an issue against sphinx here to try to understand why on earth all these new warnings popped up: sphinx-doc/sphinx#9733

@gibsondan
Copy link
Member Author

and an issue against sphinx-click to try to understand why mocking doesn't seem to work with click entry poitns: click-contrib/sphinx-click#86 (although I increasingly think we won't bother with trying to get mocking working)

Copy link
Contributor

@yuhan yuhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q management: let's pick this back up later when we/they figure out the mysterious warnings

@gibsondan gibsondan closed this Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants