Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove postinstall script & fix ENOENT error #440

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

himself65
Copy link
Sponsor Contributor

@himself65 himself65 commented Jan 29, 2024

I saw tons of ENOENT in many CIs and my local device, and we should let the maintainer or CI manually link it.

Before:
image

After:
image

Refs: pnpm/pnpm#1801, https://www.webpro.nl/scraps/compiled-bin-in-typescript-monorepo

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Jan 29, 2024 8:22pm

Copy link

codesandbox-ci bot commented Jan 29, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8c0abf7:

Sandbox Source
Vanilla Typescript Configuration
React Configuration
React TypeScript Configuration

@himself65 himself65 changed the title build: remove postinstall script build: remove postinstall script & fix ENOENT error Jan 29, 2024
@@ -0,0 +1,3 @@
#!/usr/bin/env node
// eslint-disable-next-line import/no-unresolved
import './dist/index.js';
Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

placeholder cli file to make pnpm happy

Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having ./cli.js seems a little less ideal, but it looks good generally.

@dai-shi dai-shi merged commit 20a9783 into dai-shi:main Jan 29, 2024
28 checks passed
@dai-shi
Copy link
Owner

dai-shi commented Jan 29, 2024

@himself65 Thanks for your contribution as always!

@dai-shi dai-shi mentioned this pull request Jan 30, 2024
@himself65 himself65 deleted the himself65/remove-postinstall branch January 30, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants