Modernize the Apollo Client testing approach #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current Apollo Client testing approach is based on a no longer supported library. This PR helps address this by: - Moving to the `@apollo/client` dependency (currently an RC version of 3.4) - Switching the `react-apollo` naming for `apollo-client` (`react-apollo` has been deprecated) - Simplifying the Apollo test application using Reactive Variables and our field policy API Some of the Apollo Client tests still fail, but this is a stepping stone in our React 18 work.
hwillson
commented
Jun 26, 2021
Comment on lines
+47
to
+57
| const useIncrement = () => { | ||
| return () => { | ||
| return currentState(reducer(currentState(), incrementAction)); | ||
| }; | ||
| }; | ||
|
|
||
| const useDouble = () => { | ||
| return () => { | ||
| return currentState(reducer(currentState(), doubleAction)); | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Please note that the useIncrement and useDouble naming is a bit misleading here since these are not hooks, but I kept the naming as is to line up with what createApp is expecting.
hwillson
commented
Jun 26, 2021
Comment on lines
+13
to
+15
| new webpack.DefinePlugin({ | ||
| __DEV__: JSON.stringify(process.env.NODE_ENV !== "production"), | ||
| }), |
There was a problem hiding this comment.
Apollo Client has moved away from using process.env.NODE_ENV to __DEV__ (details here). This slight tweak is intended to help Webpack recognize that.
dai-shi
approved these changes
Jun 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First off, thanks very much for putting this wonderful testing repo together. 🙇♂️ We (Apollo) are planning on using it for some of our React 18 testing. To kick things off though, we noticed this project is using a no longer supported library/version of our React integration. This PR includes a few changes to help correct this, such as:
@apollo/clientdependency (currently an RC version of 3.4)react-apollonaming forapollo-client(react-apollohas been deprecated)Is this something you would be interested in merging? This doesn't change our failed test status, but it's a start to make sure the test application is using a more current Apollo Client approach. We'll be sure to report back when we have all tests passing. Thanks!
cc @benjamn @brainkim