Skip to content

Commit

Permalink
Add comments to linger_timeout behavior about Windows
Browse files Browse the repository at this point in the history
This option is added in fluent#3644
However, there was a lack of consideration regarding the default
behavior on Windows.

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
  • Loading branch information
daipom committed Apr 4, 2022
1 parent ed9d25e commit 52c0ddb
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion lib/fluent/plugin_helper/server.rb
Expand Up @@ -267,7 +267,9 @@ module ServerTransportParams
### Socket Params ###

# SO_LINGER 0 to send RST rather than FIN to avoid lots of connections sitting in TIME_WAIT at src.
# Set positive value if needing to send FIN on closing.
# Set positive value if needing to send FIN on closing on non-Windows.
# (On Windows, Fluentd can send FIN with zero `linger_timeout` since Fluentd doesn't set 0 to SO_LINGER on Windows.
# See `socket_option.rb`.)
# NOTE:
# Socket-options can be specified from each plugin as needed, so most of them is not defined here for now.
# This is because there is no positive reason to do so.
Expand Down

0 comments on commit 52c0ddb

Please sign in to comment.