WIP - Localization / l10n #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efault, FR second (TODO), currently menu only (other UI TODO)
…dimentary french translation (will need review)
… restart the app)
…nstant language switch in other components
danielweck
commented
Mar 8, 2019
| const browseForFileOrFolder2 = browseForFileOrFolderArray[1].trim(); | ||
| const browseForFileOrFolder3 = browseForFileOrFolderArray[2].trim(); | ||
| const browseForFileOrFolder4 = browseForFileOrFolderArray[3].trim(); | ||
| const browseForFileOrFolder5 = browseForFileOrFolderArray[4].trim(); |
There was a problem hiding this comment.
This is ugly as hell, but this works fine for a first shot. TODO: regexp
There was a problem hiding this comment.
PS: i18next supports templates of course...but I haven't looked into breaking-down this particular splash message into a template-compatible form.
|
TODO:
|
|
Related Ace "core" PR: daisy/ace#223 |
…facts from the filesystem (testing non-deployed packages, not yet staged for production but ready for testing app builds)
rdeltour
requested changes
May 5, 2019
|
Thank you for your l10n peer review Romain! Tedious work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Also fixes issue #14
electron-store(JSON)en(generic English) as default / fallback language.fr(generic French) is provided (needs reviewing).i18nextto handle the JSON resources (language catalogs), simple starter API with powerful extensions: https://www.i18next.com